-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Enable some tests in runner v2 batch mode. #37363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the robustness of the Dataflow V2 runner by re-integrating specific test categories that were previously excluded. By enabling tests for window expiration and stateful ParDo operations, the change ensures more comprehensive validation of these critical functionalities within the V2 runner's batch processing capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Ok. Only two tests failed after enabling back categories: Both of them failed with However, this change also increase the number of tests running with this post-commit test task from 241 to 290, which includes the tests for states. |


Background: #20666 (comment)
I discovered that some state tests are actually skipped on Dataflow Runner V2 batch mode.
By re-enabling two previously excluded categories: `UsesOnWindowExpiration' and 'UsesStatefulParDo', we let ~50 more tests run in the post-commit workflow.