Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jan 23, 2026

Rationale for this change

Cython built code is currently failing to compile on free threaded wheels due to:

/arrow/python/build/temp.linux-x86_64-cpython-313t/_flight.cpp: In function ‘PyObject* __pyx_gb_7pyarrow_7_flight_12FlightClient_9do_action_2generator2(__pyx_CoroutineObject*, PyThreadState*, PyObject*)’:
/arrow/python/build/temp.linux-x86_64-cpython-313t/_flight.cpp:43068:110: error: call of overloaded ‘unique_ptr(NULL)’ is ambiguous
43068 |           __pyx_t_3 = (__pyx_cur_scope->__pyx_v_result->result == ((std::unique_ptr< arrow::flight::Result> )NULL));
      |                            

What changes are included in this PR?

Update comparing unique_ptr[CFlightResult] and unique_ptr[CFlightInfo] from NULL to nullptr.

Are these changes tested?

Yes via archery.

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #48965 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Jan 23, 2026

@github-actions crossbow submit wheel-manylinux-2-28-cp313-cp313t-*

@github-actions
Copy link

Revision: a96a120

Submitted crossbow builds: ursacomputing/crossbow @ actions-821088a53e

Task Status
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jan 23, 2026

I am quite confused that this just started failing on these two nightlies and the last handful of days:

this seems to fix the problem but I have no idea why it didn't fail on other places or previously. @pitrou any thoughts?

@raulcd raulcd marked this pull request as ready for review January 23, 2026 16:25
@raulcd raulcd requested a review from lidavidm as a code owner January 23, 2026 16:25
@raulcd raulcd requested a review from pitrou January 23, 2026 16:25
@raulcd
Copy link
Member Author

raulcd commented Jan 23, 2026

I validated the cython version used was the same for both the last successful build and the first failure. Based on the info from:
https://s3.amazonaws.com/arrow-data/index.html

Last successful build: https://github.com/ursacomputing/crossbow/actions/runs/21164890755/job/60867111904
First failure: https://github.com/ursacomputing/crossbow/actions/runs/21241731659/job/61121044657

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants