-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48926: [C++] Upgrade Abseil/Protobuf/GRPC bundled versions #48964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
@kou I am submitting this to show some issues I am facing and see if you have any idea on how to solve them. Basically I've tried to bump protobuf/grpc and the related abseil used by default on that version of protobuf. Building flight with bundled dependencies works great but when I want to also build google cloud cpp I start having some problems because newer abseil defines a crc32c target but crc32c also defines the same target name and Google Cloud requires both abseil and crc32c. I've tried several things locally but to be fair none of them seem to help me move forward. Any idea of how to proceed with those? |
|
googleapis/google-cloud-cpp#15402 may solve it. |
| set(ABSL_ENABLE_INSTALL ON) | ||
| fetchcontent_makeavailable(absl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| set(ABSL_ENABLE_INSTALL ON) | |
| fetchcontent_makeavailable(absl) | |
| set(ABSL_ENABLE_INSTALL OFF) | |
| fetchcontent_makeavailable(absl) |
This would prevent name collision, but pprobably cause other issues.
TBD
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)