Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jan 23, 2026

TBD

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@github-actions
Copy link

⚠️ GitHub issue #48926 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Jan 23, 2026

@kou I am submitting this to show some issues I am facing and see if you have any idea on how to solve them. Basically I've tried to bump protobuf/grpc and the related abseil used by default on that version of protobuf. Building flight with bundled dependencies works great but when I want to also build google cloud cpp I start having some problems because newer abseil defines a crc32c target but crc32c also defines the same target name and Google Cloud requires both abseil and crc32c.

-- google-cloud-cpp: CRC32C: Performing Test HAVE_WEAK_GETAUXVAL - Success
CMake Error at /build/cpp/_deps/crc32c-src/CMakeLists.txt:268 (add_library):
  add_library cannot create target "crc32c" because another target with the
  same name already exists.  The existing target is a static library created
  in source directory "/build/cpp/_deps/absl-src/absl/crc".  See
  documentation for policy CMP0002 for more details.


CMake Warning (dev) at /build/cpp/_deps/crc32c-src/CMakeLists.txt:274 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  A private source from a directory other than that of target "crc32c" has a
  relative path.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- google-cloud-cpp: Only building the google-cloud-cpp::storage component

I've tried several things locally but to be fair none of them seem to help me move forward. Any idea of how to proceed with those?

@kou
Copy link
Member

kou commented Jan 23, 2026

googleapis/google-cloud-cpp#15402 may solve it.
I'll complete the PR...

Comment on lines +1890 to +1891
set(ABSL_ENABLE_INSTALL ON)
fetchcontent_makeavailable(absl)
Copy link
Member

@rok rok Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set(ABSL_ENABLE_INSTALL ON)
fetchcontent_makeavailable(absl)
set(ABSL_ENABLE_INSTALL OFF)
fetchcontent_makeavailable(absl)

This would prevent name collision, but pprobably cause other issues.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants