-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-43510: [PYTHON] Move NumPy specific tests to separate test file. #48899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these empty lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the extra blank lines. Thanks for pointing it out.
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several linting failures, that's why the CI job is failing, can you take a look?
https://github.com/apache/arrow/actions/runs/21179073114/job/60943377596?pr=48899
|
Hello @raulcd, I will look into it and get back to you. |
This PR reorganizes Python array tests by moving NumPy-specific tests out of
python/pyarrow/tests/test_array.pyinto a new file,python/pyarrow/tests/test_array_numpy.py.The goal is to keep
test_array.pyfocused on core Arrow array behavior whileisolating tests that depend on NumPy, which is an optional runtime dependency.
What this PR does:
@pytest.mark.numpyinto a separate filetest_array.pyWhat this PR does NOT do:
Related issue: GH-43510