Skip to content

Conversation

@cka-dev
Copy link
Contributor

@cka-dev cka-dev commented Jan 14, 2026

refactor NoteDatabase creation to AppModule and remove redundant companion object

resolves #34

@cka-dev cka-dev requested a review from tiwiz January 14, 2026 17:39
@cka-dev cka-dev requested a review from romanofranz as a code owner January 14, 2026 17:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cka-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the application's database instantiation process. By relocating the NoteDatabase creation logic into the AppModule, it enhances modularity and improves the separation of concerns. This change also eliminates a redundant companion object from the NoteDatabase class, streamlining the codebase and making dependency management more explicit through the application's dependency injection module.

Highlights

  • Database Creation Refactoring: The logic for creating the NoteDatabase instance has been moved from the NoteDatabase class itself to the AppModule.
  • Redundant Companion Object Removal: The companion object within NoteDatabase.kt, which previously housed the getDatabase factory method, has been entirely removed as its functionality is now handled by AppModule.
  • Dependency Management: This refactoring centralizes database dependency provision within the AppModule, aligning with best practices for dependency injection.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refactors the NoteDatabase creation by moving the logic to an AppModule and leveraging Hilt for dependency injection. This is a great improvement as it replaces the manual singleton pattern with a more robust and standard approach. The code is now cleaner and better follows modern Android architecture practices. I have one minor suggestion to further improve maintainability by extracting a hardcoded string into a constant.

@tiwiz tiwiz merged commit a3bae83 into main Jan 20, 2026
3 checks passed
@tiwiz tiwiz deleted the db-issue branch January 20, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: rely on Hilt for Room database instead of manual singleton

2 participants