AGP 9.0 plus dependency updates #193
Conversation
- Upgrade to Gradle 9.3.0 - Upgrade to Hilt 2.59 - Upgrade to Baseline Profile plugin 1.5.0-alpha01 - Upgrade to Google OSS plugin 0.10.10 - Upgrade to Kotlin 2.3.0 - Upgrade to KSP 2.3.4 - Adapt to built-in kotlin in AGP - Add a missing bom entry in :watchface - Ensure that we dont use transtive deps in :wear APK copying - Disable built-in kotlin in :wear:watchface - Rewrite :wear tasks that add generated APK and XML resources
Summary of ChangesHello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the project's build system, moving to Android Gradle Plugin (AGP) 9.0 and Gradle 9.3.0. It includes a broad sweep of dependency updates across various AndroidX and third-party libraries. The primary motivation for these changes is to fix a critical runtime crash involving Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively updates the project to Android Gradle Plugin 9.0 and refreshes numerous dependencies, which is a significant and important maintenance task. The changes correctly adopt modern AGP practices, such as removing redundant Kotlin plugin applications and leveraging the variant API for managing generated sources, which improves build correctness and performance. The update of the Gradle wrapper scripts to their latest versions also brings welcome improvements in robustness and security. I've added one suggestion in wear/build.gradle.kts to make a part of the custom build logic more robust.
| @TaskAction | ||
| fun taskAction() { | ||
| val apkFile = apkDirectory.asFile.get().resolve("default_watchface.apk") | ||
| val sourceApkFile = apkFileCollection.files.single().listFiles().single { it.extension == "apk" } |
There was a problem hiding this comment.
The current implementation to find the source APK file is a bit brittle. listFiles() can return null if the directory does not exist or an I/O error occurs, which would lead to a NullPointerException. It's safer to handle this potential null case to prevent the build from failing with an unhelpful error.
val sourceApkFile = (apkFileCollection.singleFile.listFiles() ?: emptyArray()).single { it.extension == "apk" }2 participants
#192 based on this, trying to fix build with nav3 runtime still crashing: