Allozaur/mcp mvp #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d per-chat overrides
…endency between ChatStore and ConversationsStore
refactor(models): Use new API fetch utilities refactor(props): Use new API fetch utilities
refactor(agentic-client): Extend BaseClient for store integration refactor(chat-client): Extend BaseClient for store integration refactor(conversations-client): Extend BaseClient for store integration
allozaur
commented
Jan 27, 2026
Comment on lines
+2
to
+6
| import { ChatMessageActions, ChatMessageMcpPromptContent } from '$lib/components/app'; | ||
| import { getMessageEditContext } from '$lib/contexts'; | ||
| import { MessageRole, McpPromptVariant } from '$lib/enums'; | ||
| import type { DatabaseMessageExtraMcpPrompt } from '$lib/types'; | ||
| import ChatMessageEditForm from './ChatMessageEditForm.svelte'; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| import { ChatMessageActions, ChatMessageMcpPromptContent } from '$lib/components/app'; | |
| import { getMessageEditContext } from '$lib/contexts'; | |
| import { MessageRole, McpPromptVariant } from '$lib/enums'; | |
| import type { DatabaseMessageExtraMcpPrompt } from '$lib/types'; | |
| import ChatMessageEditForm from './ChatMessageEditForm.svelte'; | |
| import { ChatMessageActions, ChatMessageEditForm, ChatMessageMcpPromptContent } from '$lib/components/app'; | |
| import { getMessageEditContext } from '$lib/contexts'; | |
| import { MessageRole, McpPromptVariant } from '$lib/enums'; | |
| import type { DatabaseMessageExtraMcpPrompt } from '$lib/types'; |
Comment on lines
+30
to
+107
| let hoveredArgKey = $state<string | null>(null); | ||
| let argumentEntries = $derived(Object.entries(prompt.arguments ?? {})); | ||
| let hasArguments = $derived(prompt.arguments && Object.keys(prompt.arguments).length > 0); | ||
| let hasContent = $derived(prompt.content && prompt.content.trim().length > 0); | ||
| let serverSettingsMap = $derived.by(() => { | ||
| const servers = mcpStore.getServers(); | ||
| const map = new SvelteMap<string, MCPServerSettingsEntry>(); | ||
| for (const server of servers) { | ||
| map.set(server.id, server); | ||
| } | ||
| return map; | ||
| }); | ||
| function getServerFavicon(): string | null { | ||
| const server = serverSettingsMap.get(prompt.serverName); | ||
| return server ? getFaviconUrl(server.url) : null; | ||
| } | ||
| function getServerDisplayName(): string { | ||
| const server = serverSettingsMap.get(prompt.serverName); | ||
| if (!server) return prompt.serverName; | ||
| return mcpStore.getServerLabel(server); | ||
| } | ||
| let contentParts = $derived.by((): ContentPart[] => { | ||
| if (!prompt.content || !hasArguments) { | ||
| return [{ text: prompt.content || '', argKey: null }]; | ||
| } | ||
| const parts: ContentPart[] = []; | ||
| let remaining = prompt.content; | ||
| const valueToKey = new SvelteMap<string, string>(); | ||
| for (const [key, value] of argumentEntries) { | ||
| if (value && value.trim()) { | ||
| valueToKey.set(value, key); | ||
| } | ||
| } | ||
| const sortedValues = [...valueToKey.keys()].sort((a, b) => b.length - a.length); | ||
| while (remaining.length > 0) { | ||
| let earliestMatch: { index: number; value: string; key: string } | null = null; | ||
| for (const value of sortedValues) { | ||
| const index = remaining.indexOf(value); | ||
| if (index !== -1 && (earliestMatch === null || index < earliestMatch.index)) { | ||
| earliestMatch = { index, value, key: valueToKey.get(value)! }; | ||
| } | ||
| } | ||
| if (earliestMatch) { | ||
| if (earliestMatch.index > 0) { | ||
| parts.push({ text: remaining.slice(0, earliestMatch.index), argKey: null }); | ||
| } | ||
| parts.push({ text: earliestMatch.value, argKey: earliestMatch.key }); | ||
| remaining = remaining.slice(earliestMatch.index + earliestMatch.value.length); | ||
| } else { | ||
| parts.push({ text: remaining, argKey: null }); | ||
| break; | ||
| } | ||
| } | ||
| return parts; | ||
| }); | ||
| let showArgBadges = $derived(hasArguments && !isLoading && !loadError); | ||
| let isAttachment = $derived(variant === McpPromptVariant.ATTACHMENT); | ||
| let textSizeClass = $derived(isAttachment ? 'text-sm' : 'text-md'); | ||
| let maxHeightStyle = $derived( | ||
| isAttachment ? 'max-height: 10rem;' : 'max-height: var(--max-message-height);' | ||
| ); |
Owner
Author
There was a problem hiding this comment.
Re-order with imports, props, context, variables, functions, effects, lifecycle order
Comment on lines
+47
to
+49
| { value: ColorMode.SYSTEM, label: 'System', icon: Monitor }, | ||
| { value: ColorMode.LIGHT, label: 'Light', icon: Sun }, | ||
| { value: ColorMode.DARK, label: 'Dark', icon: Moon } |
Owner
Author
There was a problem hiding this comment.
Let's have these options as constant from lib/constants
Owner
Author
There was a problem hiding this comment.
move to lib/components/app/actions
Comment on lines
+2
to
+10
| /** | ||
| * CollapsibleInfoCard - Reusable collapsible card component | ||
| * | ||
| * Used for displaying thinking content, tool calls, and other collapsible information | ||
| * with a consistent UI pattern. | ||
| * | ||
| * Features auto-scroll during streaming: scrolls to bottom automatically, | ||
| * stops when user scrolls up, resumes when user scrolls back to bottom. | ||
| */ |
Owner
Author
There was a problem hiding this comment.
Suggested change
| /** | |
| * CollapsibleInfoCard - Reusable collapsible card component | |
| * | |
| * Used for displaying thinking content, tool calls, and other collapsible information | |
| * with a consistent UI pattern. | |
| * | |
| * Features auto-scroll during streaming: scrolls to bottom automatically, | |
| * stops when user scrolls up, resumes when user scrolls back to bottom. | |
| */ |
We want to have JSDoc comments only in index files
Owner
Author
There was a problem hiding this comment.
It's probably not needed anymore after removing the clients layer and moving back business logic to stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.