Skip to content

Conversation

@szczygiel-m
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused console properties and the schemaIdAwareSerialization feature from the codebase. The changes streamline the Topic model, configuration, and related processing logic by eliminating deprecated functionality.

Changes:

  • Removed schemaIdAwareSerialization-related code from Topic API, builders, validators, and message wrappers
  • Removed topic labels feature including validators, tests, and UI components
  • Removed deprecated console configuration properties and endpoints
  • Cleaned up related test files and configuration

Reviewed changes

Copilot reviewed 63 out of 63 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
hermes-api/src/main/java/pl/allegro/tech/hermes/api/Topic.java Removed schemaIdAwareSerialization field and labels from Topic model
hermes-api/src/main/java/pl/allegro/tech/hermes/api/TopicLabel.java Deleted TopicLabel class
hermes-api/src/main/java/pl/allegro/tech/hermes/api/TopicWithSchema.java Updated to remove schemaIdAwareSerialization and labels parameters
hermes-common/src/main/java/pl/allegro/tech/hermes/common/message/wrapper/AvroMessageSchemaIdAwareContentWrapper.java Deleted schema-aware content wrapper implementation
hermes-common/src/main/java/pl/allegro/tech/hermes/common/message/wrapper/CompositeMessageContentWrapper.java Removed schema-aware wrapper from composite wrapper
hermes-common/src/main/java/pl/allegro/tech/hermes/common/di/factories/ObjectMapperFactory.java Removed schemaIdSerializationEnabled parameter
hermes-common/src/main/java/pl/allegro/tech/hermes/common/metric/DeserializationMetrics.java Removed schema-aware deserialization metrics
hermes-management/src/main/java/pl/allegro/tech/hermes/management/domain/topic/validator/TopicLabelsValidator.java Deleted labels validator
hermes-management/src/main/java/pl/allegro/tech/hermes/management/domain/topic/validator/TopicValidator.java Removed labels validation logic
hermes-management/src/main/java/pl/allegro/tech/hermes/management/config/TopicProperties.java Removed allowedTopicLabels and defaultSchemaIdAwareSerializationEnabled properties
hermes-management/src/main/java/pl/allegro/tech/hermes/management/config/console/ConsoleProperties.java Removed unused console configuration properties
hermes-management/src/main/java/pl/allegro/tech/hermes/management/infrastructure/console/HttpConsoleConfigurationRepository.java Deleted HTTP console configuration repository
hermes-management/src/main/java/pl/allegro/tech/hermes/management/infrastructure/console/ClasspathFileConsoleConfigurationRepository.java Deleted classpath console configuration repository
hermes-frontend/src/main/java/pl/allegro/tech/hermes/frontend/publishing/preview/MessagePreviewFactory.java Removed schemaIdAwareSerializationEnabled parameter
hermes-console/src/api/topic.ts Removed schemaIdAwareSerializationEnabled and TopicLabel interface
integration-tests/src/integrationTest/java/pl/allegro/tech/hermes/integrationtests/management/TopicManagementTest.java Removed topic labels test cases
hermes-test-helper/src/main/java/pl/allegro/tech/hermes/test/helper/builder/TopicBuilder.java Removed schemaIdAwareSerialization and labels builder methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants