Make cookie banner appear on every page #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
force-pushed
the
kgf-ac-cookie
branch
from
b0e29d2 to
4b58839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the cookie banner instance to
BaseLayoutso it will appear on every page of the Museum (excluding the top-level "meta" index, which does not involveBaseLayout).This also adds a "Clear local storage" button to the top-level index to provide an easy-to-access way to reset all state including the cookie banner, sign-in/registration, gift shop, etc.
The cookie banner component itself includes one fix to specify text color, to avoid white-on-white on the Early Home Computers Event page.
I have removed the
endslot fromLayoutto avoid confusion, as this was the only thing it was used for, and the layout it was provided within is not used across all Museum pages.I'm adding those with whom I discussed this yesterday as reviewers; as discussed, I'll merge it myself after a day or so if no feedback is received. In the meantime, I will also work to apply this behind #89 and sync that after this is merged.