Enforce LF line endings to fix Windows Docker setup #2114
Conversation
Ashishworks
force-pushed
the
fix-2100-line-endings
branch
from
f7430b1 to
b78bba7
Compare
|
Hi maintainers, the checks are green |
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @Ashishworks, See the comments below and also fix the commit message.
.gitattributes
Outdated
| * text=auto eol=lf | ||
|
|
||
| *.py text eol=lf | ||
| *.sh text eol=lf | ||
| Dockerfile text eol=lf | ||
| Makefile text eol=lf | ||
| *.yml text eol=lf | ||
| *.yaml text eol=lf | ||
| *.env text eol=lf |
There was a problem hiding this comment.
Isn't this enough?
| * text=auto eol=lf | |
| *.py text eol=lf | |
| *.sh text eol=lf | |
| Dockerfile text eol=lf | |
| Makefile text eol=lf | |
| *.yml text eol=lf | |
| *.yaml text eol=lf | |
| *.env text eol=lf | |
| * text=auto eol=lf |
There was a problem hiding this comment.
Agreed, the single * text=auto eol=lf rule is enough. I’ve updated the PR to keep only that and removed the file-specific entries.
There was a problem hiding this comment.
This was an unintended line-ending change caused by renormalization. I’ve reverted it and the PR now only updates .gitattributes.
Ashishworks
force-pushed
the
fix-2100-line-endings
branch
from
5010ee3 to
090d8d0
Compare
Signed-off-by: Ashish <ashish061104@gmail.com> A
Ashishworks
force-pushed
the
fix-2100-line-endings
branch
from
090d8d0 to
236c83c
Compare
Thanks for the review @keshav-space Simplified .gitattributes to just * text=auto eol=lf Please re-review the latest update when possible |
2 participants
Fixes #2100
Windows clones may convert LF to CRLF, causing Docker/Linux to fail with python\r in shebang lines (e.g., manage.py).
This PR enforces LF line endings using .gitattributes and renormalizes files accordingly.
Tested:
docker compose run vulnerablecode ./manage.py import --list works on Windows with Docker.