Allow to read mac address from spi flash #1532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains patch which again allows the MAC address to be read from SPI. It reverts commit ba74bcf from /Xilinx/u-boot-xlnx/ repo and adds changes which was present in patch until version 3.0.1 Signed-off-by: akluczyn <adrian.kluczynski@gmail.com>
Collaborator
|
Hi @akluczyn Have you confirmed this patch works on a Z1/Z2 image? IIRC the reason this was removed between PYNQ v3.0 and 3.1 is that the function we used to read from EEPROM had been deprecated. I did look into it for a bit to find an alternative but ran out of time before release. |
Author
|
Hi @jogomojo, I have confirmed that it works on Z2 image - I have built an image via docker and after that MAC was correctly retrieved from SPI. |
Collaborator
|
Thanks for confirming @akluczyn I'll test this myself this week and pull it onto the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that since version 3.1 (when petalinux 2024.1 is used) on the Pynq z2 board the MAC address is not retrieved from the flash memory.
This pull request contains patch which again allows the MAC address to be read from SPI. This patch reverts commit ba74bcf from /Xilinx/u-boot-xlnx/ repo and adds changes which was present in patch until version 3.0.1 (commit d75f95a from PYNQ repo)