forked from zerodha/gokiteconnect
-
Notifications
You must be signed in to change notification settings - Fork 1
[pull] master from zerodhatech:master #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
121
commits into
VarunBatraIT:master
Choose a base branch
from
zerodha:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,745
−26,962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new MF routes, fixed SIP deletion HTTP method
fix: test failiure for cancel mf sip
Support for go modules
feat: Add trigger_price and GetMFOrdersByDate
This commit adds the order margins API. A few internal refactors are made to the .Do function to allow using json content type.
feat: add order-margins API
Fixes to code quality issues
* Updated mock response Updated MF SIP info mock response to reflect correct JSON field name. * Fixed MF SIPS mock response
* Add OI support in Historical Data This adds OI support in historical data: https://kite.trade/docs/connect/v3/historical/#oi-data Unfortunately, it is incompatible with previous versions - I am updating test as well. * Update market_test.go * Change oI to OI
OI support in historical data, mock_responses submodule, tags in order response, github actions
feat: auction fields, variety in place order, tests for all order varieties
feat: add charges,leverage and unit tests for order margins
feat: Add methods for virtual contract note API
* fix: Synchronize access to lastPingTime in Ticker struct * fix: Synchronize access to lastPingTime in Ticker struct second pass * updated lasPingTime visibility, gitignored .vscode/settings.json * update: updated as specified
Use PAN instead of Pan in struct
feat: Add Full User Profile
* chore: update go-test.yml
fix: genHolAuthURL auth URL and json tag
Add `GetLoginURLWithparams()` to support `redir_params`.
feat: add mtf in holdings and orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )