Skip to content

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 21, 2026

Description

This PR is addressing some of the UI issues that design team reported to input system.
Removing wrong background and using component header colors.

No “Shadow” section headers
Use headers similar to component headers that allows for buttons
  • Changed background color to match unity header components (Dark/Light themes).
  • Added a hover effect to march unity header components (Dark/Light themes).

Before:
Screenshot 2026-01-21 at 13 45 33

After:

Screen.Recording.2026-01-21.at.13.44.05.mov

JIRA: https://jira.unity3d.com/browse/ISX-2340

Testing status & QA

No testing is needed.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 21, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title Input/UI input action map window header background color Fix: headers under Action Properties similar to gameObject component headers Jan 21, 2026
@josepmariapujol-unity josepmariapujol-unity marked this pull request as ready for review January 21, 2026 12:49
@u-pr
Copy link
Contributor

u-pr bot commented Jan 21, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

ISX-2340 - Partially compliant

Compliant requirements:

  • Remove “Shadow” section headers
  • Use headers similar to component headers that allow for buttons
  • Toolbar should use toolbar style:
    • Height 20px

Non-compliant requirements:

  • Fix Auto-Save toggle padding/inline styles
  • Use add icon for Add buttons (and add-more icon when multiple add actions exist)
  • Action properties should use reorderable lists (remove/move options provided)
  • Consider using a single helpbox for default setting explanation (reduce repetitive message/link)

Requires further human verification:

  • Toolbar should use toolbar style:
    • Font regular (12pt)
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

Small, theme/style-only changes, but needs quick verification across light/dark and common UI states (hover/focus/selected).
🏅 Score: 82

Clean and targeted styling update, but the new header typography may conflict with the ticket’s “regular” font requirement and needs UI verification across states/themes.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Spec Mismatch

The header styling enforces -unity-font-style: bold, while the ticket calls out toolbar text as regular; confirm this matches the intended “component header” look (and doesn’t regress the toolbar-style requirement).

.body-panel-header {
    background-color: var(--unity-colors-toolbar-background);
    border-bottom-color: var(--unity-colors-toolbar-border);
    flex-direction: row;
    margin-left: 0;
    margin-right: 0;
    margin-top: 0;
    margin-bottom: 0;
    padding-left: 5px;
    padding-right: 3px;
    padding-top: 4px;
    padding-bottom: 4px;
    border-bottom-width: 1px;
    height: 20px;
    min-height: 20px;
    font-size: 12px;
    -unity-font-style: bold;
    align-items: center;
    justify-content: flex-start;
    -unity-text-align: middle-left;
}
UI State Coverage

Only :hover is added for .properties-foldout-toggle; ensure other interaction states (focused/active/selected/expanded) remain readable and consistent with Unity editor styling in both themes.

.properties-foldout-toggle {
    background-color: var(--input-editor-colors-properties-foldout);
    height: 20px;
}

.properties-foldout-toggle:hover {
    background-color: var(--input-editor-colors-properties-foldout-toggle-hover);
}
Theme Consistency

New color tokens were introduced/changed for dark theme; verify contrast and consistency with surrounding toolbar/background tokens and ensure no other theme variants rely on the previous values.

:root {
    --input-editor-colors-properties-foldout: #3E3E3E;
    --input-editor-colors-properties-foldout-border: #1A1A1A;
    --input-editor-colors-properties-foldout-toggle-hover: #474747;
}
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr
Copy link
Contributor

u-pr bot commented Jan 21, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 21, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2331   +/-   ##
========================================
  Coverage    77.95%   77.95%           
========================================
  Files          476      476           
  Lines        97453    97466   +13     
========================================
+ Hits         75971    75982   +11     
- Misses       21482    21484    +2     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_2022.3_project 75.47% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3_project 75.27% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.17% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.18% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.5 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.18% <ø> (+<0.01%) ⬆️
inputsystem_Windows_2022.3 5.54% <ø> (+<0.01%) ⬆️
inputsystem_Windows_2022.3_project 75.61% <ø> (+0.01%) ⬆️
inputsystem_Windows_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.49% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 77.50% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josepmariapujol-unity josepmariapujol-unity changed the title Fix: headers under Action Properties similar to gameObject component headers FIX: headers under Action Properties similar to gameObject component headers Jan 21, 2026
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks like a straight downgrade but who am I to fight the designers. Looked at the headers in project wide actions window and input actions window view with Light/Dark modes. No problems interacting with the headers, adding interactions or tabbing through the headers.

@josepmariapujol-unity josepmariapujol-unity merged commit bdd4741 into develop Jan 22, 2026
108 of 109 checks passed
@josepmariapujol-unity josepmariapujol-unity deleted the input/ui-input-action-map-window-header-background-color branch January 22, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants