This repository was archived by the owner on Jun 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 207
chore: switch optimism testnet from kovan to goerli #217
Open
annieke
wants to merge
1
commit into
Uniswap:main
Choose a base branch
from
annieke:op/switch-kovan-goerli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,9 +46,9 @@ export const USDC_OPTIMISM = new Token( | |
| 'USDC', | ||
| 'USD//C' | ||
| ) | ||
| export const USDC_OPTIMISTIC_KOVAN = new Token( | ||
| SupportedChainId.OPTIMISTIC_KOVAN, | ||
| '0x3b8e53b3ab8e01fb57d0c9e893bc4d655aa67d84', | ||
| export const USDC_OPTIMISM_GOERLI = new Token( | ||
| SupportedChainId.OPTIMISM_GOERLI, | ||
| '0x7E07E15D2a87A24492740D16f5bdF58c16db0c4E', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where did you pull this address from?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a usdc contract i deployed to unblock another team for testing: https://goerli-optimism.etherscan.io/address/0x7e07e15d2a87a24492740d16f5bdf58c16db0c4e#code currently it's our canonical usdc token on optimism goerli https://github.com/ethereum-optimism/ethereum-optimism.github.io/blob/bf1d49a8cd99db70beb7ff8d7adb6fb9c22f1b78/optimism.tokenlist.json#L1870-L1880 |
||
| 6, | ||
| 'USDC', | ||
| 'USD//C' | ||
|
|
@@ -115,7 +115,7 @@ export const USDC: { [chainId in SupportedChainId]: Token } = { | |
| [SupportedChainId.ARBITRUM_ONE]: USDC_ARBITRUM, | ||
| [SupportedChainId.OPTIMISM]: USDC_OPTIMISM, | ||
| [SupportedChainId.ARBITRUM_RINKEBY]: USDC_ARBITRUM_RINKEBY, | ||
| [SupportedChainId.OPTIMISTIC_KOVAN]: USDC_OPTIMISTIC_KOVAN, | ||
| [SupportedChainId.OPTIMISM_GOERLI]: USDC_OPTIMISM_GOERLI, | ||
| [SupportedChainId.POLYGON]: USDC_POLYGON, | ||
| [SupportedChainId.POLYGON_MUMBAI]: USDC_POLYGON_MUMBAI, | ||
| [SupportedChainId.GOERLI]: USDC_GOERLI, | ||
|
|
@@ -281,8 +281,8 @@ export const WRAPPED_NATIVE_CURRENCY: { [chainId: number]: Token | undefined } = | |
| 'WETH', | ||
| 'Wrapped Ether' | ||
| ), | ||
| [SupportedChainId.OPTIMISTIC_KOVAN]: new Token( | ||
| SupportedChainId.OPTIMISTIC_KOVAN, | ||
| [SupportedChainId.OPTIMISM_GOERLI]: new Token( | ||
| SupportedChainId.OPTIMISM_GOERLI, | ||
| '0x4200000000000000000000000000000000000006', | ||
| 18, | ||
| 'WETH', | ||
|
|
@@ -370,7 +370,7 @@ export const TOKEN_SHORTHANDS: { [shorthand: string]: { [chainId in SupportedCha | |
| [SupportedChainId.ARBITRUM_ONE]: USDC_ARBITRUM.address, | ||
| [SupportedChainId.OPTIMISM]: USDC_OPTIMISM.address, | ||
| [SupportedChainId.ARBITRUM_RINKEBY]: USDC_ARBITRUM_RINKEBY.address, | ||
| [SupportedChainId.OPTIMISTIC_KOVAN]: USDC_OPTIMISTIC_KOVAN.address, | ||
| [SupportedChainId.OPTIMISM_GOERLI]: USDC_OPTIMISM_GOERLI.address, | ||
| [SupportedChainId.POLYGON]: USDC_POLYGON.address, | ||
| [SupportedChainId.POLYGON_MUMBAI]: USDC_POLYGON_MUMBAI.address, | ||
| [SupportedChainId.GOERLI]: USDC_GOERLI.address, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this symbol come from? Why does this use ö instead of oe, like the rest of the labels?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goerli in this same file uses the symbol, copypastaed here for consistency
widgets/src/constants/chainInfo.ts
Line 93 in e434298