Adding a more informative warning when user don't enter a single mode… #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
requested changes
Oct 3, 2020
Collaborator
toobaz
left a comment
toobaz
left a comment
There was a problem hiding this comment.
Thanks @lucascr91, some comments
| def __init__(self, models): | ||
| self.models = models | ||
| self.num_models = len(models) | ||
| self.num_models = self.new_len() |
Collaborator
There was a problem hiding this comment.
This check is not worth adding a new method, please do it inside __init__ and before checking the length
| """ | ||
| Adding a more informative warning when user don't enter a single model as a list | ||
| """ | ||
| if isinstance(self.models,list): |
Collaborator
There was a problem hiding this comment.
Notice that as of now, other containers (sets, tuples...) would have worked fine. I'm OK with requiring a list, but please add a docstring to __init__ (in the format of add_line's one) that documents this.
| if isinstance(self.models,list): | ||
| return len(self.models) | ||
| else: | ||
| raise ValueError('Models must be a list') |
Collaborator
There was a problem hiding this comment.
Models -> "models", list -> list of trained models
| self.num_models = self.new_len() | ||
| self.reset_params() | ||
| self.extract_data() | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing problem raised by issued #57
I create a more informative error message