feat(user card) - Update User Card to SHINE styles (part 2) #2123
Conversation
| interface Props { | ||
| /** | ||
| * Account name for screen readers |
There was a problem hiding this comment.
NIT: wrong description. It's an internal only component, we could also skip jsdoc all together.
packages/stacks-svelte/src/components/UserCard/AvatarDeleted.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I don't think we need this file anymore @ttaylor-stack
CGuindon
left a comment
CGuindon
left a comment
There was a problem hiding this comment.
Is there an easy way to have the height of the container that the username is in be the same as the avatar height for both the Original poster and New contributor on the larger size. It's missing 1px of padding above and below I think to match.
@CGuindon updating original poster is fine I can do that now however with the new contributor in the figma it matches the height of the other user badges not the avatar. Do we still want to increase the height to match the avatars? Also if that's the case do we want to update all user badges to match the height of the avatar? |
packages/stacks-svelte/src/components/UserCard/AvatarDeleted.svelte
Outdated
Show resolved
Hide resolved
…m/StackExchange/Stacks into spark-127/update-user-card-part-2
No my mistake, just original poster is fine. |
|
|
||
| <li> | ||
| <Badge text={type} type="user" userType={type} size="sm" /> | ||
| {#if tooltip && type === "new"} |
There was a problem hiding this comment.
@ttaylor-stack NIT, no need here to check also for type ==="new". This can be left generic. If tooltip is defined we show the tooltip otherwise we don't.
| @@ -1,12 +1,17 @@ | |||
| <script lang="ts" module> | |||
| export type Size = "sm" | "lg" | undefined; | |||
| export type AwardBlings = "first" | "second" | "third" | undefined; | |||
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
I have left a couple of minor comments. Once those are addressed I think this is good enough to be merged. Thanks @ttaylor-stack
SPARK-127
Figma
This PR covers part 2 of the User Card component which includes: