-
Notifications
You must be signed in to change notification settings - Fork 20
1451 interpolate_simulation_result does not yield consistent timepoints #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1451 interpolate_simulation_result does not yield consistent timepoints #1482
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 97.31% 97.29% -0.03%
==========================================
Files 187 187
Lines 16017 16019 +2
==========================================
- Hits 15587 15585 -2
- Misses 430 434 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition :)
My comments only refer to minor details.
pycode/memilio-simulation/memilio/simulation/bindings/data/analyze_result.h
Show resolved
Hide resolved
simplify usage of tolerances
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Closes #1451
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)