-
Notifications
You must be signed in to change notification settings - Fork 4
Template GMGPolar class on DensityProfileCoefficients #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EmilyBourne
merged 27 commits into
main
from
ebourne_gmgpolar_template_density_profile_coefficients
Jan 27, 2026
Merged
Template GMGPolar class on DensityProfileCoefficients #137
EmilyBourne
merged 27 commits into
main
from
ebourne_gmgpolar_template_density_profile_coefficients
Jan 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 89.15% 89.40% +0.24%
==========================================
Files 91 91
Lines 5239 5238 -1
==========================================
+ Hits 4671 4683 +12
+ Misses 568 555 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julianlitz
approved these changes
Dec 29, 2025
…te_density_profile_coefficients
…te_density_profile_coefficients
…mplate_density_profile_coefficients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #131 inheritance must be removed from kernels in order to port them to GPU. Concepts are used as a drop-in replacement for superclasses to enforce prototypes. This work is continued with the use of
DensityProfileCoefficientsinGMGPolar.This PR should be reviewed and merged after #136
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):