Skip to content

Conversation

@lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Nov 19, 2025

Description

Add producer module to create light calorimetry data products. Creates new subdirectory Calorimetry to store the module and fcls. Over 3 years since the first commit! Reco2/caf level changes only.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links

Accompanying PRs: SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- moved truth validation to a separate function
- added lower/upper threshold for PE per channel
- added fcl param to turn on/off evaluating all planes
- option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet
- merge the two previous trees into one
- match-type can now differentiate between event/slice level easily
Version v09_89_01, patch release for SBN2024A
nathanielerowe and others added 14 commits December 17, 2025 20:41
…ask; add upper limit to avoid nonlinearity effects (rough idea)
…ghted avg fix

- BCFM has at most, one bcfm<->one slice <-> one opflash association, even if there are opflashes in both tpcs. Explicitly look for an opflash (within a fcl parameter window) in the opposite TPC if the slice has spacepoints in both TPCs
- bug fix for weighted average; need to treat each TPC as independent for calculating the weighted avg
- add to standard mc/data reco2 workflow
- add SCE tag to cafmaker sce for data and mc
@lynnt20 lynnt20 marked this pull request as ready for review January 21, 2026 23:11
@lynnt20 lynnt20 requested a review from linyan-w January 21, 2026 23:15
@linyan-w linyan-w moved this from Draft to Waiting on Reviewer in SBND 2025 Fall Production Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Waiting on Reviewer

Development

Successfully merging this pull request may close these issues.

4 participants