-
Notifications
You must be signed in to change notification settings - Fork 3
Optimize pedigree simulation codebase #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8a1aadf
cran prep
smasongarrison 6fdd2d3
Merge branch 'main' into dev_main
smasongarrison e1b35b8
Merge branch 'main' into dev_main
smasongarrison d8ea03d
Update buildComponent.R
smasongarrison 385c01f
Rename helpPedigree.R to helpSimulatePedigree.R
smasongarrison 18ff0e5
Optimize simulatePedigree within-generation logic
smasongarrison e5988bb
Update simulatePedigree.R
smasongarrison d6bbd71
DOC
smasongarrison f738092
Update simulatePedigree.R
smasongarrison 3395da9
build in tests of optimized version
smasongarrison 4f48947
Improve pedigree simulation and update benchmarks
smasongarrison f2344fc
Refactor pedigree simulation and add within-generation module
smasongarrison e442af0
Refactor and optimize pedigree simulation functions
smasongarrison e631152
Remove unimplemented 'indexed' beta option and improve tests
smasongarrison bbd4cfc
more resiliant
smasongarrison 686bb9a
Optimize generation indexing in buildBetweenGenerations
smasongarrison 1fee960
Refactor pedigree simulation functions for clarity
smasongarrison f4fbb4a
Refactor and optimize buildBetweenGenerations_optimized
smasongarrison 538d2ee
Create benchmarkng nopointers.png
smasongarrison 57784cf
Refactor and simplify pedigree simulation functions
smasongarrison 50abd37
Add beta (optimized) versions of pedigree helper functions
smasongarrison c7b5a82
Refactor pedigree simulation helpers and add family ID prefix
smasongarrison 99d4653
Refactor pedigree simulation helpers and add family ID prefix
smasongarrison 0c54b00
Merge branch 'dev_main' of https://github.com/R-Computing-Lab/BGmisc …
smasongarrison 06ca022
move
smasongarrison 3ab04ac
Apply suggestions from code review
smasongarrison 07a139a
Update markPotentialChildren.Rd
smasongarrison 109e55c
Simplify documentation and enhance pedigree tests
smasongarrison 7ee37c3
Normalize beta parameter string aliases before calling downstream fun…
Copilot d999d18
stylr
smasongarrison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These newly added inline comments are hard to parse and contain multiple spelling errors, which makes the algorithm rationale unclear. Please rewrite or remove them (keeping only a concise explanation of the stopping criterion and precision tradeoff).