feature/upgrade vue web terminal 3.4.1 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elasticdotventures
commented
Jan 25, 2026
elasticdotventures
commented
- Upgrade vue-web-terminal from 3.2.2 to 3.4.1
- Install licensed PATRON font files locally
Changes: - Update package.json to vue-web-terminal 3.4.1 - Update TheXTerm.vue imports (use default import for Terminal) - Remove CSS theme import, add theme="dark" prop (v3.3.1 breaking change) - Manually installed vue-web-terminal 3.4.1 from npm registry Breaking changes handled: - v3.3.1: Theme configuration moved from CSS imports to component props - v3.4.0: Plugin no longer requires global registration via createTerminal() All existing functionality preserved: - Custom commands (hello, meet) - WebSocket integration - Idle timer auto-execution - TerminalApi methods Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add PATRON.ttf, PATRON.woff, PATRON.woff2 to public/fonts/ - Add PATRON fonts to src/assets/fonts/ for @import usage - Update PromptExecutionLogo.vue to use local fonts instead of onlinewebfonts.com - Removes font loading errors from browser console Font files from: PATRON Multimedia License.zip Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Regenerated lockfile after manual package installations - Fixes Cloudflare build error: 'lockfile had changes, but lockfile is frozen' Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Deploying promptexecutionwebsite with
|
| Latest commit: |
66402ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e59de912.promptexecutionwebsite.pages.dev |
| Branch Preview URL: | https://feature-upgrade-vue-web-term.promptexecutionwebsite.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the vue-web-terminal dependency and wires it up as a plugin, while also switching the PromptExecution branding fonts from a remote CDN to locally hosted licensed font files.
Changes:
- Bump
vue-web-terminalfrom3.2.2to3.4.1and register its plugin (createTerminal) on the Vue app soTerminalApiworks correctly. - Update
TheXTerm.vueto use the componenttheme="dark"prop instead of importing the dark theme CSS directly, and adjust imports forTerminalApi/Command. - Replace external Patron font loading with local
PATRONfont files (TTF/WOFF/WOFF2) underpublic/fontsand corresponding@font-facerules inPromptExecutionLogo.vue.
Reviewed changes
Copilot reviewed 4 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Upgrades vue-web-terminal to 3.4.1, enabling the newer API and theme-prop behavior. |
src/main.ts |
Imports createTerminal from vue-web-terminal and installs it as a plugin so TerminalApi calls in components function as intended. |
src/components/TheXTerm.vue |
Points the Terminal component at the new plugin setup, sets theme="dark", and refines imports/types for TerminalApi and Command. |
src/components/PromptExecutionLogo.vue |
Switches logo typography to use locally hosted Patron/Exodar fonts via @font-face with /fonts/... URLs. |
public/fonts/PATRON.woff2 / public/fonts/PATRON.woff / public/fonts/PATRON.ttf |
Provide the Patron font in multiple web formats for use by the logo styles via /fonts/PATRON.* URLs. |
src/assets/fonts/PATRON.woff2 / src/assets/fonts/PATRON.woff |
Add additional copies of the Patron font under src/assets/fonts, which currently are not referenced by any CSS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+11
| // @ts-ignore - TypeScript can't resolve the export but it exists at runtime | ||
| import { createTerminal } from 'vue-web-terminal'; |
There was a problem hiding this comment.
Using // @ts-ignore here hides all TypeScript checking for this import and diverges from the way other untyped dependencies are handled (for example src/vue-native-websocket-vue3.d.ts declares a module instead). To keep type safety and stay consistent with the rest of the codebase, consider adding or extending a .d.ts declaration for vue-web-terminal (including createTerminal) instead of suppressing the error at the usage site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.