-
Notifications
You must be signed in to change notification settings - Fork 0
PILOT-7924: fixup the download link is not compatible with platform #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the CLI download link logic to return platform-specific URLs and adds tests to cover each platform.
- Added
platformimport and runtime branching inget_latest_cli_versionfor Linux, Windows, and macOS. - Introduced
test_get_download_link_by_platformto validate platform-specific download URLs. - Bumped package version and updated CI workflow to use
ubuntu-latest.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/utils/aggregated.py | Import platform and select download URL by platform |
| tests/app/utils/test_aggregated.py | New parametrized test for platform-based download links |
| pyproject.toml | Bump version from 3.19.6 to 3.19.7 |
| .github/workflows/update_compatible_version.yml | Change runner to ubuntu-latest |
Contributor
QXgu
reviewed
Jun 16, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
QXgu
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The old notification message always report to linux download link in windows and macos platform. The PR will display download link based on platform.
JIRA Issues
PILOT-7924
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
Add new test cases for different platform.
Versions