🩹[Patch]: Workflow improvements #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR aims to update Dependabot configuration to run daily with a 7-day cooldown period, but includes additional unrelated changes and contains a critical configuration error.
Changes:
- Modified
.github/dependabot.ymlto change schedule from weekly to daily and attempted to add a cooldown configuration - Updated GitHub Actions versions in three workflow files with pinned commit hashes
- Deleted
.github/release.ymlfile containing release note configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/dependabot.yml | Changed schedule interval to daily and added invalid cooldown configuration |
| .github/workflows/Linter.yml | Updated actions/checkout to v6.0.2 and super-linter to v8.3.2 with commit hash pinning |
| .github/workflows/Auto-Release.yml | Updated actions/checkout to v6.0.2 and PSModule/Auto-Release to v1.9.5 with commit hash pinning |
| .github/workflows/Action-Test.yml | Updated actions/checkout to v6.0.2 with commit hash pinning |
| .github/release.yml | Completely removed release notes configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MariusStorhaug
changed the title
MariusStorhaug
changed the title
MariusStorhaug
changed the title
MariusStorhaug
changed the title
- Created a new GitHub Actions workflow (`Release.yml`) to automate the release process on pull request events. - Configured permissions for creating releases and commenting on pull requests. feat: Implement Helpers module with versioning - Added `Helpers.psd1` and `Helpers.psm1` files to define the Helpers module with version `999.0.0`. - Implemented various utility functions for module management and dependency resolution. test: Add PSScriptAnalyzer configuration for Helpers module - Created `PSScriptAnalyzer.Tests.psd1` to define rules for code quality checks on the Helpers module. chore: Implement main script for module importation - Added `main.ps1` script to handle the importation of the Helpers module into the PowerShell session. - Ensured cleanup of previous module instances before importing the new version.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/Release.yml:7
- Switching the trigger from
pull_request_targettopull_requestwill causeGITHUB_TOKENto be read-only on forked PRs, even if workflowpermissionsrequest write. If this workflow needs to create releases/comments or push tags/notes for fork PRs, it will fail; consider whetherpull_request_target(with appropriate hardening) is required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MariusStorhaug
changed the title
MariusStorhaug
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/Release.yml:37
- The PR description says release notes are managed by the Auto-Release action and lists
PSModule/Auto-Release@..., but this workflow now usesPSModule/Release-GHRepository@...and renames the job/labels. Please update the PR description (or the workflow) so the documentation matches the actual behavior and pinned action.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MariusStorhaug
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release updates and improves several aspects of the project's GitHub Actions workflows and related configuration files. The main changes include refactoring the release workflow for clarity and security, updating dependencies and action versions to use specific commit SHAs, and cleaning up unused or redundant configuration files.
Workflow and CI/CD Improvements:
.github/workflows/Auto-Release.ymlto.github/workflows/Release.yml, updated its trigger topull_request(instead ofpull_request_target), restricted its scope to changes inaction.ymlandsrc/**, and changed the main job and step names fromAuto-ReleasetoRelease. Also replaced the action used for releases toPSModule/Release-GHRepository@88c70461c8f16cc09682005bcf3b7fca4dd8dc1aand updated the checkout action to a specific SHA with credentials disabled for improved security.Action-TestandLinterworkflows to use specific commit SHAs for theactions/checkoutandsuper-linter/super-linteractions, and setpersist-credentials: falsefor security. Also, in theLinterworkflow, disabled some validators and set additional environment variables.Dependency and Automation Configuration:
Configuration Cleanup:
.github/linters/.jscpd.jsonfile, which is no longer needed..github/release.ymlconfiguration for automatically generated release notes, as this is now handled by the updated release workflow.Other Notable Changes:
action.ymlto reference the new script location atsrc/main.ps1instead ofscripts/main.ps1.