feat: PyOpenMagnetics FREE version with TAS format #7
+15,975
−731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete FREE version including: - Fluent Design API (Design.flyback(), Design.buck(), etc.) - Basic examples (flyback_design.py, buck_inductor.py) - TAS interchange format for basic DC-DC converters - Simple optimization and reporting - Documentation and architect tools TAS features: - Basic modulation types (PWM, PFM, Hysteretic) - Simple control modes (Voltage/Current mode) - Component models: inductors, capacitors, switches, diodes - 4 DC-DC examples: buck, boost, buck-boost, flyback Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a FREE version of PyOpenMagnetics with comprehensive TAS (Topology Agnostic Structure) format support for basic DC-DC converters. It includes extensive test coverage, enhanced C++ header documentation, design API improvements, and architectural tools.
Changes:
- Added TAS interchange format with models for waveforms, inputs, outputs, and components supporting basic DC-DC topologies
- Added 9 new test files covering wire, winding, utils, simulation, settings, plotting, losses, design builder, and bobbin functionality
- Enhanced C++ headers with comprehensive Doxygen documentation for all 11 binding modules
- Added documentation infrastructure (MkDocs, contributing guide, examples, installation guide)
- Added software architect tools for code analysis and pattern documentation
- Added pre-commit scripts and push blocker for managing FREE/PRO split
Reviewed changes
Copilot reviewed 73 out of 75 changed files in this pull request and generated 27 comments.
Show a summary per file
| File | Description |
|---|---|
| tas/models/* | TAS format models for topology-agnostic converter design |
| tas/examples/*.json | Example TAS documents for buck, boost, buck-boost, flyback converters |
| tests/test_*.py | Comprehensive test coverage for PyOpenMagnetics functionality |
| src/*.h, src/module.cpp | Enhanced C++ header documentation with Doxygen comments |
| scripts/*.sh | Pre-commit check and push blocker scripts |
| docs/* | MkDocs documentation with installation, examples, contributing guides |
| api/models/* | Dataclass models for topology, specs, operating points |
| api/architect/* | Code analysis and pattern documentation tools |
| notebooks/*.ipynb | Updated Jupyter notebooks with corrected Unicode characters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
+148
| scatter = ax.scatter(core_losses, copper_losses, s=sizes, c=colors, | ||
| edgecolors='black', linewidths=1, alpha=0.8) |
There was a problem hiding this comment.
Variable scatter is not used.
Suggested change
| scatter = ax.scatter(core_losses, copper_losses, s=sizes, c=colors, | |
| edgecolors='black', linewidths=1, alpha=0.8) | |
| ax.scatter(core_losses, copper_losses, s=sizes, c=colors, | |
| edgecolors='black', linewidths=1, alpha=0.8) |
| power calculations, and reflected waveform transformations. | ||
| """ | ||
| import pytest | ||
| import math |
There was a problem hiding this comment.
Import of 'math' is not used.
Collaborator
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| from dataclasses import dataclass | ||
| from typing import List | ||
| from enum import Enum | ||
| import math |
There was a problem hiding this comment.
Import of 'math' is not used.
| if tree.body and isinstance(tree.body[0], ast.Expr): | ||
| if isinstance(tree.body[0].value, ast.Constant): | ||
| has_docstring = True | ||
| except SyntaxError: |
There was a problem hiding this comment.
'except' clause does nothing but pass and there is no explanatory comment.
Suggested change
| except SyntaxError: | |
| except SyntaxError: | |
| # Ignore syntax errors here; docstring detection is best-effort. | |
| # Full syntax error handling is performed when analyzing the module below. |
| for py_file in path.rglob("*.py"): | ||
| try: | ||
| results.append(analyze_module(str(py_file))) | ||
| except Exception: |
There was a problem hiding this comment.
'except' clause does nothing but pass and there is no explanatory comment.
Suggested change
| except Exception: | |
| except Exception: | |
| # Intentionally ignore errors for individual modules so that analysis | |
| # can continue for the rest of the package. |
Comment on lines
+266
to
+267
| except ImportError: | ||
| pass |
There was a problem hiding this comment.
'except' clause does nothing but pass and there is no explanatory comment.
Suggested change
| except ImportError: | |
| pass | |
| except ImportError as e: | |
| if verbose: | |
| print(f"[Pareto plot skipped - plotting dependency not installed: {e}]") |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete FREE version including:
TAS features: