Skip to content

Conversation

@dermatz
Copy link
Collaborator

@dermatz dermatz commented Jan 30, 2026

This pull request focuses on improving the MageForge Inspector's compatibility and maintainability by migrating its CSS from Tailwind to pure Vanilla CSS, ensuring it works seamlessly across all Magento 2 frontend themes (including both Luma and Hyvä). It also introduces automated functional tests to validate the Inspector's assets, CSS conventions, and Alpine.js loading behavior.

Key changes:

Inspector CSS Migration and Compatibility:

  • Migrated Inspector component CSS from Tailwind to pure Vanilla CSS, using the mageforge-* prefix for all classes, removed the Tailwind build dependency, and updated the CSS location to src/view/frontend/web/css/inspector.css for better compatibility and namespace isolation.
  • Updated the Inspector template (inspector.phtml) to automatically load Alpine.js from a CDN only if it is not already present (ensuring compatibility with both Luma and Hyvä themes), with appropriate detection and logging.

Automated Functional Testing:

  • Added a comprehensive Inspector functionality test step to the GitHub Actions workflow. This step verifies Inspector asset existence, correct CSS prefix usage, absence of Tailwind dependencies, Alpine.js auto-loading, and compatibility with both Luma and Hyvä themes.
  • Updated the workflow summary to include confirmation that Inspector compatibility tests have passed.

@github-actions github-actions bot added documentation Improvements or additions to documentation Frontend labels Jan 30, 2026
@dermatz dermatz closed this Jan 30, 2026
@dermatz dermatz reopened this Jan 30, 2026
@dermatz dermatz merged commit 3411257 into main Jan 30, 2026
19 checks passed
@dermatz dermatz deleted the fix-inspector-luma branch January 30, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants