feat: enhance InspectorHints to support MageWire Templates #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in MageWire Templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the Inspector Hints feature, primarily focused on ensuring that inspector attributes are injected only when appropriate and preventing issues with certain content types. The changes add more robust content checks, improve compatibility with AJAX/Magewire requests, and refine how comment markers are injected to avoid breaking JavaScript strings.
Content Handling Improvements:
Added multiple checks in
InspectorHints.phpto prevent wrapping content that is JSON, a script tag, a Magewire component, or a template for JS templating engines, ensuring inspector attributes are only injected into suitable HTML content.Changed comment marker injection to avoid introducing new lines, preventing potential issues when rendered inside JavaScript variables.
Request Type Handling:
Httprequest dependency and used it to disable Inspector Hints for AJAX/API requests and Magewire requests, preventing DOM diffing issues and unnecessary processing for these types of requests. [1] [2] [3]… in MageWire Templates