Use "zh-Hant" for language code, follows RFC 5646 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The language code should be `zh` (as in `en` and `fr` of the other two directories) - The formatting of the language code, the separator, and the script code `zh-Hant` is according to RFC 5646 https://datatracker.ietf.org/doc/rfc5646/ Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the directory names within
SBOM-Quality-Management/Telco-SBOM-Guide:ZH_Hans->zh-Hans:ZH_Hant->zh-Hant:Rationale:
zh(consistent withen,fr, etc in other places of this repo)zh-Hansis according to RFC 5646 https://datatracker.ietf.org/doc/rfc5646/This PR did not change the file name, as the English and the French versions also use the non-standard all-uppercase
ENandFR. So keep it that way, for now, for internal consistency within theSBOM-Quality-Management/Telco-SBOM-Guidedirectory.This PR also did not rename the directory
jptoja."JP" is a country code, while "ja" is a language code.
To be precise, we should use
ja(like inOpen-Source-Policy-Templates/ISO-IEC-5230-(OpenChain 2.1))This directory
Open-Source-Policy-Templates/OpenChain-2.0-(Pre-ISO-IEC-5230)uses a more consistent language code for both directory and file names.zh-Hantfor directory name.de,en, andzh-Hantfor file name.If possible, we should follow this example.