Skip to content

Fix pre commit config #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbampton merged 2 commits into from
Jan 27, 2026
Merged

Fix pre commit config #250

jbampton merged 2 commits into from
Jan 27, 2026

Conversation

@Subham-KRLX
Copy link
Contributor

@Subham-KRLX Subham-KRLX commented Jan 26, 2026

Fixes #243

Added the missing .pre-commit-config.yaml file that was causing the lint workflow to fail. The configuration includes:

  • File validation hooks (trailing whitespace, YAML/JSON validation, etc.)
  • Prettier for code formatting
  • Markdownlint for documentation quality

@Subham-KRLX Subham-KRLX marked this pull request as draft January 26, 2026 15:25
@Subham-KRLX Subham-KRLX force-pushed the fix-pre-commit-config branch 5 times, most recently from 86fcbe4 to 1e7c0da Compare January 26, 2026 15:56
@Subham-KRLX
Copy link
Contributor Author

Subham-KRLX commented Jan 26, 2026

Hi @jbampton, this PR adds the .pre-commit-config.yaml file to enable linting hooks (trailing whitespace, YAML validation, Prettier, and Markdownlint). The checks are now running and detected pre-existing formatting issues in README.md (line length, code block languages, heading styles). These are good catches that should be fixed. Would you like me to fix README.md to pass all linting checks so this PR can be merged cleanly? This will establish solid lint standards for the project going forward.

@jbampton
Copy link
Member

jbampton commented Jan 26, 2026

Yes you can fix the linter errors in the Markdown and YAML in this PR. Thanks

@jbampton jbampton self-assigned this Jan 26, 2026
@jbampton jbampton added this to Next Jan 26, 2026
@github-project-automation github-project-automation bot moved this to In progress in Next Jan 26, 2026
@jbampton jbampton added this to the February Sprint milestone Jan 26, 2026
@Subham-KRLX
Fix pre-commit: Add .pre-commit-config.yaml
babe91f 
- Add comprehensive pre-commit configuration file
- Include hooks for file validation (trailing whitespace, end-of-file, etc.)
- Add YAML validation for user profile files
- Add Prettier formatting for JS, CSS, HTML, Markdown, YAML, JSON
- Add Markdownlint for documentation quality
- Exclude _site/, node_modules/, and package-lock.json

Fixes NextCommunity#243
@Subham-KRLX
Apply pre-commit formatting fixes
875badc 
- Apply Prettier formatting to YAML, JS, CSS files
- Fix trailing whitespace and end-of-file issues
- Fix markdownlint errors in README.md:
  * Add language specifiers to code blocks (MD040)
  * Add .markdownlint.yaml to disable MD013 (line-length) and MD036 (emphasis-as-heading)
- Ensure all linting checks pass
@Subham-KRLX Subham-KRLX force-pushed the fix-pre-commit-config branch from 1e7c0da to 875badc Compare January 27, 2026 01:52
@Subham-KRLX Subham-KRLX marked this pull request as ready for review January 27, 2026 01:55
jbampton
jbampton approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Next Jan 27, 2026
@jbampton jbampton merged commit acbd279 into NextCommunity:main Jan 27, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Next Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbampton jbampton jbampton approved these changes

Assignees

@jbampton jbampton

Labels

code style tests

Projects

Next
Status: Done

Milestone

February Sprint

Development

Successfully merging this pull request may close these issues.

Fix pre-commit

2 participants

@Subham-KRLX @jbampton