-
Notifications
You must be signed in to change notification settings - Fork 0
Budget app #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Budget app #2
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 6861727 | Generic High Entropy Secret | 2378040 | config/initializers/devise.rb | View secret |
| 6862393 | Generic High Entropy Secret | 2378040 | config/initializers/devise.rb | View secret |
| 6862393 | Generic High Entropy Secret | 926b600 | config/initializers/devise.rb | View secret |
| 6862393 | Generic High Entropy Secret | 5aeecef | config/initializers/devise.rb | View secret |
| 6862449 | Generic High Entropy Secret | 926b600 | config/initializers/devise.rb | View secret |
| 6862449 | Generic High Entropy Secret | 5aeecef | config/initializers/devise.rb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MosDevx 😊,
Good job so far! 👏
You have done well reaching this milestone point, but there are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Good presentation demo ✔️
- The app functionality works properly ✔️
Required Changes ♻️
- Kindly consider giving appropriate credit to Gregoire Vella on Behance the author of the original design, as required by the Creative Commons license of the design. and consider adding a link for it.
Check the comments under the review.
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
codecaiine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MosDevx ,
Your project is complete! There is nothing else to say other than... it's time to merge it ![]()
Congratulations! 🎉
Highlights
- Good presentation demo ✔️
- The app functionality works properly ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me (@codecaiine) in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

In this branch following changes done: