Skip to content

Conversation

@MosDevx
Copy link
Owner

@MosDevx MosDevx commented Jun 10, 2023

In this branch following changes done:

Splash screen
    - A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.

Sign up and log in pages
    - The user should be able to register in the app with full name, email and password (all mandatory).
    - The user can log into the app using email and password.
    - If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).

Home page (categories page)
    - When the user logs in, they are presented with the categories page.
    - For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
    - When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
    - There is a button "add a new category" at the bottom that brings the user to the page to create a new category.

Transactions page
    - For a given category, the list of transactions is presented, ordered by the most recent.
    - At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
    - There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
    - When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new category" page
    The user fills out a form to create a new category, indicating their name and icon (both mandatory).
    - The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
    - When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new transaction" page
    - The user fills out a form to create a new transaction with:
        name (mandatory)
        amount (mandatory)
        categories (mandatory at least one)
    - The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
   - When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.
  • Create unit and integration tests
- Add styling with tailwind

@gitguardian
Copy link

gitguardian bot commented Jun 10, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
6861727 Generic High Entropy Secret 2378040 config/initializers/devise.rb View secret
6862393 Generic High Entropy Secret 2378040 config/initializers/devise.rb View secret
6862393 Generic High Entropy Secret 926b600 config/initializers/devise.rb View secret
6862393 Generic High Entropy Secret 5aeecef config/initializers/devise.rb View secret
6862449 Generic High Entropy Secret 926b600 config/initializers/devise.rb View secret
6862449 Generic High Entropy Secret 5aeecef config/initializers/devise.rb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@addod19
Copy link

addod19 commented Jun 10, 2023

Hi @MosDevx,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that is invalid because you did not follow the correct Git-flow workflow. What is Git-flow? Git-flow is creating a PR branch from a feature branch like for example my-budget into the dev branch, that is Git-flow. Kindly pay attention to the from and into in the PR

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants