-
Notifications
You must be signed in to change notification settings - Fork 153
Add z image turbo warmup script #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Musisoul, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new benchmark script for the Z-Image-Turbo model, designed to include a warmup phase for performance evaluation. Concurrently, it refactors existing benchmark scripts by removing redundant Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new warmup script for z_image_turbo and cleans up existing benchmark scripts by removing redundant profiling level settings. The changes are straightforward and improve the codebase. I've suggested a small refactoring in the new script to reduce code duplication and improve clarity.
| # warmup | ||
| pipe.generate( | ||
| seed=seed, | ||
| prompt=prompt, | ||
| target_shape=target_shape, | ||
| negative_prompt=negative_prompt, | ||
| save_result_path=save_result_path, | ||
| ) | ||
|
|
||
| # Generate video | ||
| pipe.generate( | ||
| seed=seed, | ||
| prompt=prompt, | ||
| target_shape=target_shape, | ||
| negative_prompt=negative_prompt, | ||
| save_result_path=save_result_path, | ||
| return_result_tensor=True, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of improvements that can be made here:
- The arguments passed to
pipe.generateare almost identical for the warmup and the actual generation call, leading to code duplication. To improve maintainability, you can store the common arguments in a dictionary and unpack them during the calls. - The comment on line 46,
# Generate video, is misleading since this is a text-to-image (t2i) task that generates a.pngfile. It should be changed to# Generate image.
Here's a suggestion that addresses both points:
generate_args = {
"seed": seed,
"prompt": prompt,
"target_shape": target_shape,
"negative_prompt": negative_prompt,
"save_result_path": save_result_path,
}
# warmup
pipe.generate(**generate_args)
# Generate image
pipe.generate(**generate_args, return_result_tensor=True)
No description provided.