Skip to content

Conversation

@Musisoul
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Musisoul, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new benchmark script for the Z-Image-Turbo model, designed to include a warmup phase for performance evaluation. Concurrently, it refactors existing benchmark scripts by removing redundant os imports and explicit profiling environment variable settings, streamlining their execution. A profiling decorator has also been added to the Z-Image runner's pipeline method, enhancing performance monitoring capabilities.

Highlights

  • New Warmup Script: A new script, run_lightx2v_z_image_turbo_with_warmup.py, has been added to facilitate benchmarking and performance evaluation for the Z-Image-Turbo model, including a dedicated warmup phase.
  • Profiling Integration: The run_pipeline method within the z_image_runner.py now includes a @ProfilingContext4DebugL1 decorator, enabling more granular performance monitoring.
  • Script Cleanup: Existing benchmark scripts (run_lightx2v_qwen_2512_with_warmup.py, run_lightx2v_qwen_edit_2511_with_warmup.py, run_lightx2v_wan22_t2v_8gpu_with_warmup.py) have been cleaned up by removing redundant import os statements and explicit PROFILING_DEBUG_LEVEL environment variable settings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new warmup script for z_image_turbo and cleans up existing benchmark scripts by removing redundant profiling level settings. The changes are straightforward and improve the codebase. I've suggested a small refactoring in the new script to reduce code duplication and improve clarity.

Comment on lines +37 to +54
# warmup
pipe.generate(
seed=seed,
prompt=prompt,
target_shape=target_shape,
negative_prompt=negative_prompt,
save_result_path=save_result_path,
)

# Generate video
pipe.generate(
seed=seed,
prompt=prompt,
target_shape=target_shape,
negative_prompt=negative_prompt,
save_result_path=save_result_path,
return_result_tensor=True,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are a couple of improvements that can be made here:

  1. The arguments passed to pipe.generate are almost identical for the warmup and the actual generation call, leading to code duplication. To improve maintainability, you can store the common arguments in a dictionary and unpack them during the calls.
  2. The comment on line 46, # Generate video, is misleading since this is a text-to-image (t2i) task that generates a .png file. It should be changed to # Generate image.

Here's a suggestion that addresses both points:

generate_args = {
    "seed": seed,
    "prompt": prompt,
    "target_shape": target_shape,
    "negative_prompt": negative_prompt,
    "save_result_path": save_result_path,
}

# warmup
pipe.generate(**generate_args)

# Generate image
pipe.generate(**generate_args, return_result_tensor=True)

@helloyongyang helloyongyang merged commit 7c5bbd7 into main Jan 29, 2026
2 checks passed
@helloyongyang helloyongyang deleted the bench_260129 branch January 29, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants