Skip to content

Conversation

@domfournier
Copy link
Collaborator

No description provided.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small requests

# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
#	simpeg_drivers/components/factories/misfit_factory.py
#	simpeg_drivers/driver.py
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.16%. Comparing base (36b3d29) to head (af13442).

Files with missing lines Patch % Lines
simpeg_drivers/driver.py 91.17% 2 Missing and 1 partial ⚠️
simpeg_drivers/joint/driver.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    91.11%   91.16%   +0.04%     
===========================================
  Files          117      117              
  Lines         6402     6437      +35     
  Branches       777      782       +5     
===========================================
+ Hits          5833     5868      +35     
  Misses         379      379              
  Partials       190      190              
Files with missing lines Coverage Δ
...drivers/components/factories/directives_factory.py 96.65% <100.00%> (+0.01%) ⬆️
...peg_drivers/components/factories/misfit_factory.py 80.00% <100.00%> (+1.05%) ⬆️
...ivers/electromagnetics/frequency_domain/options.py 91.07% <100.00%> (+0.16%) ⬆️
simpeg_drivers/joint/options.py 100.00% <100.00%> (ø)
...rivers/natural_sources/magnetotellurics/options.py 98.11% <100.00%> (+0.07%) ⬆️
simpeg_drivers/natural_sources/tipper/options.py 100.00% <100.00%> (ø)
simpeg_drivers/options.py 96.19% <100.00%> (+0.01%) ⬆️
simpeg_drivers/potential_fields/gravity/uijson.py 100.00% <100.00%> (ø)
simpeg_drivers/joint/driver.py 89.51% <81.81%> (-0.38%) ⬇️
simpeg_drivers/driver.py 85.31% <91.17%> (+0.58%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants