MDBF-1159 Libvirt - collect system logs as a step LogFile #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanLiviuVarzaru
force-pushed
the
MDBF-1159
branch
5 times, most recently
from
b0064f5 to
04c9ce2
Compare
Collaborator
Author
|
@grooverdan I assigned you for review because you were the original implementer of the collection mechanism. Thank you for your time! (FYI, this example is https://jira.mariadb.org/browse/MDEV-38628) Test: https://buildbot.dev.mariadb.org/#/builders/809/builds/4 Where a step failure is present, logs are collected. |
When an error occurs, displaying system logs in standard output may not be beneficial if they do not provide additional information that could help with debugging the issue. This was initially implemented as a trap, triggered whenever the scripts exit with a failure. See: MDBF-1130 (MariaDB/buildbot@bbb5955) Sometimes, the errors of interest are located at the beginning of the log, but they are obscured by a large number of system logs. Collecting system logs could be done into a file that is uploaded at the buildbot step level. This can be implemented by defining the logfiles parameter at the step level. See: https://docs.buildbot.net/latest/manual/configuration/steps/shell_command.html
RazvanLiviuVarzaru
force-pushed
the
MDBF-1159
branch
from
04c9ce2 to
cbea175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs, displaying system logs in standard output may not be beneficial if they do not provide additional information that could help with debugging the issue.
This was initially implemented as a trap, triggered whenever the scripts exit with a failure. See: MDBF-1130 (bbb5955)
Sometimes, the errors of interest are located at the beginning of the log, but they are obscured by a large number of system logs. Collecting system logs could be done into a file that is uploaded at the buildbot step level.
This can be implemented by defining the logfiles parameter at the step level. See: https://docs.buildbot.net/latest/manual/configuration/steps/shell_command.html