refactor(mainpage): add mainpagelayout util #6671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
approved these changes
Oct 17, 2025
Collaborator
|
Can we use the boxid for the amplitude mapping too? |
hjpalpha
approved these changes
Oct 17, 2025
ElectricalBoy
force-pushed
the
mainpage-util
branch
2 times, most recently
from
b6af001 to
3a9dfd4
Compare
Rathoz
approved these changes
Nov 4, 2025
Collaborator
Rathoz
left a comment
Rathoz
left a comment
There was a problem hiding this comment.
LGTM
Can you do a final check if any wiki is missing?
Rathoz
approved these changes
Nov 10, 2025
Collaborator
|
apparently merge conflicts again :p |
ElectricalBoy
force-pushed
the
mainpage-util
branch
from
64b4686 to
8f2cc31
Compare
ElectricalBoy
force-pushed
the
mainpage-util
branch
from
8f2cc31 to
7035926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
How did you test this change?
dev in dota2/rocketleague