Fix tool mark disappearing with small tool diameter in g-code preview widget #3741
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool marker disappears if its diameter less then some value but not equal zero (for example if diameter from tool table is used as wear corrector)
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Collaborator
|
I don't think that it makes sense to update the sample configs to have the same value as the default (ie zero). I feel that it should be some appropriate value dependent on the units of the config. Also, the new parameter would need adding to the documentation (docs/src/config/ini-config.adoc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool marker disappears if its diameter less then some value but not equal zero (for example if diameter from tool table is used as wear corrector)