-
Notifications
You must be signed in to change notification settings - Fork 0
feat: [키링/뭉치] 탭 분류 - 3 (퀵필터 구현 및 카테고리 탭바 개선) #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giljihun
wants to merge
11
commits into
develop
Choose a base branch
from
feature/키링뭉치-탭-분류-3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "feature/\uD0A4\uB9C1\uBB49\uCE58-\uD0ED-\uBD84\uB958-3"
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- workshopToggle 프로퍼티 여기로 이전 - 키링카테고리, 번들 카테고리 분류 - fetchDataForCategory 카테고리 -> 데이터타입으로 변경
- WorkshopBundle/KeyringGridView.swift
- 스크롤한 경우를 대응하지 않았었음.
- 기존엔 텍스트 영역 -> 정확히 카테고리 갯수에 나눠서 맞춰지는 영역 크기
- 주요: 최신순 정렬버튼 바텀과 떨어진 거리
- 케이스를 정의해서, 다른 버튼이 생기거나 수정 소요가 있어도 쉽습니다.
Member
Member
|
Member
|
타이틀 [키링/뭉치]에서 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

🎯 PR 내용
Summary
1. 퀵필터 구현 (라디오버튼 스타일)
2. 만들기 메뉴 위치 고정
3. CategoryTabBar 개선
.contentShape(Rectangle())추가로 터치 영역 확대4. 파일 구조
5. 참고:
tabBarMinimizeBehavior미동작 이슈.tabBarMinimizeBehavior(.onScrollDown)이 Workshop에서 동작하지 않음.원인:
📱 스크린샷 (UI 변경 시)
ScreenRecording_01-25-2026.20-52-37_1.MP4
🔗 관련 이슈
✅ 체크리스트