Skip to content

Conversation

@Eeems
Copy link
Collaborator

@Eeems Eeems commented Jan 25, 2026

Summary by CodeRabbit

  • Chores
    • CI/CD now runs explicit debug and non-debug build variants and generates distinct debug artifacts and names.
    • Build and device pipelines propagate a debug flag so debug variants are produced consistently across platforms.
    • Build tooling upgraded (Nuitka bump) and build invocation flags added to enable debug-specific compilation options.
    • Build scripts refined for more consistent debug build invocation and artifact/report naming.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026

Walkthrough

Adds a debug matrix axis to CI workflows and threads a DEBUG_BUILD flag through the build script and Makefile, enabling conditional debug builds, debug-specific Nuitka flags, and debug-suffixed artifact naming.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
/.github/workflows/main.yml
Introduces matrix.debug (0,1) for remote/device/remarkable jobs; job names append " (debug)" when matrix.debug==1; passes DEBUG_BUILD=${{ matrix.debug }} into build steps; debug artifact names include -debug.
Build System
Makefile
Adds CODEXCTL_FLAGS variable conditioned on DEBUG_BUILD==1 (adds --debug --no-debug-c-warnings --no-debug-immortal-assumptions); injects $(CODEXCTL_FLAGS) into the Nuitka build invocation; updates Nuitka version from 2.7.12 to 2.8.10.
Build Script
scripts/github-make-executable.sh
Forwards DEBUG_BUILD environment variable into the make invocation; minor here-string whitespace refactor (<<<"$line"); retains output parsing and log-level handling.

Sequence Diagram(s)

sequenceDiagram
  participant GH as GitHub Actions (matrix)
  participant Job as CI Job (remote/device)
  participant Script as scripts/github-make-executable.sh
  participant Make as Makefile / build
  participant Nuitka as Nuitka compiler
  participant Art as Artifact Upload

  rect rgba(220,230,250,0.5)
  GH->>Job: start job with matrix.debug (0 | 1)
  end

  Job->>Script: run script with DEBUG_BUILD=${matrix.debug}
  Script->>Make: invoke `make` with DEBUG_BUILD env
  Make->>Nuitka: add CODEXCTL_FLAGS when DEBUG_BUILD==1
  Nuitka-->>Make: produce executable and reports
  Make->>Art: upload artifacts (append `-debug` when DEBUG_BUILD==1)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: adding a debug build flag (via CODEXCTL_FLAGS and DEBUG_BUILD) and upgrading Nuitka from 2.7.12 to 2.8.10.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@Eeems Eeems merged commit bc8485c into main Jan 26, 2026
14 checks passed
@Eeems Eeems deleted the debug branch January 26, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants