Add validation for LabelAttentionClassifier head configuration #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LabelAttentionClassifierwas missing validation for head configuration constraints, allowing invalid configurations that cause shape mismatches at runtime whenembedding_dimis not divisible byn_head.Changes
LabelAttentionClassifier.__init__:embedding_dimmust be divisible byn_head(prevents shape mismatch inc_projlayer)n_headmust be divisible byn_kv_head(required for Group Query Attention)TextEmbeddervalidation pattern for consistencyExample
Invalid configurations now fail fast with clear error messages:
Previously this would fail later with cryptic tensor shape errors in
c_proj.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.