Skip to content

LACS-Dungeons Check Availability #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xxAtrain223 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

LACS-Dungeons Check Availability #6202

xxAtrain223 wants to merge 2 commits into from

Conversation

@xxAtrain223
Copy link
Contributor

@xxAtrain223 xxAtrain223 commented Jan 25, 2026 •
edited by github-actions bot
Loading

Fixes #5433. This feels like a hack, so alternative solutions are welcome.

Build Artifacts

@Malkierian
Copy link
Contributor

Malkierian commented Jan 26, 2026 •
edited
Loading

Perhaps, instead of setting the EventChkInf flags like that in SetInLogic and then exclusively checking the flags, we could have a map of LogicVal -> EventChkInf that can be searched in addition to the LogicVal itself in GetInLogic? Right now, we'd need to have separate maps in the future for each flag type, but I think that might be better for preserving LogicVal functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LACS-Dungeons Check Availability

2 participants

@xxAtrain223 @Malkierian