fix crash when generating decoupled entrances with boss shuffle #6189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
commented
Jan 21, 2026
serprex
force-pushed
the
fix-blue-ganon
branch
from
61a8b88 to
ac47bdf
Compare
regression from ganon's tower shuffle
serprex
force-pushed
the
fix-blue-ganon
branch
2 times, most recently
from
19c04b0 to
fda80fa
Compare
serprex
force-pushed
the
fix-blue-ganon
branch
from
d8d135b to
5195c40
Compare
Contributor
|
Does that entrance work correctly? In general the ones with _1 to _3 after the normal number should never be used. |
Contributor
Author
needed entrance index, in code we remap it to outside ganon's castle (coming out hyrule castle drain as child) |
serprex
force-pushed
the
fix-blue-ganon
branch
from
92b6a87 to
cc573ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression from ganon's tower shuffle
entrance indexes need to be unique, hacked around this using
ENTR_OUTSIDE_GANONS_CASTLE_1_2to have blue warp assigned to ganon's castle point to outside castlean insight here is that for entrance rando Ganon's Tower's boss room is the opening stairway, & the castle is the temple (seems obvious in retrospect)
Build Artifacts