Agrega soporte facturas cfdi nomina #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 26, 2026 19:48
- Renamed download-catalog.inteface.ts → download-catalog.interface.ts
- Renamed download-rule.service.inteface.ts → download-rule.service.interface.ts
- Updated all imports in 5 files to use the correct filenames
2. Fixed Code Style Inconsistencies in InvoiceService
- Standardized object property spacing (path:endpoint → path: endpoint)
- Fixed inconsistent indentation in getStatus() and create() methods
3. Fixed Method Naming Inconsistency in DownloadRequestService
- Removed Async suffix from methods to match the pattern used in other services:
- getXmlsAsync → getXmls
- getMetadataItemsAsync → getMetadataItems
- downloadPackageAsync → downloadPackage
- downloadSatRequestAsync → downloadSatRequest
- downloadSatResponseAsync → downloadSatResponse
- searchAsync → searchByDate
4. Removed Dead Code
- Deleted sdk-constants.ts which was unused and duplicated values from date-utils.ts
5. Fixed Security Issue
- Fixed rejectUnauthorized: false in HTTP client factory to be conditional based on settings.debug
6. Fixed Minor Code Style Issues
- Fixed var → const in download-rule.service.ts
- Fixed inconsistent JSDoc comment indentation
- Cleaned up extra blank lines and trailing whitespace
- Fixed function indentation in date-utils.ts
- Add form-data ^4.0.4 to fix CVE-2025-7783 (predictable boundary) - Upgrade axios to 1.13.4 to fix DoS vulnerability - Upgrade glob, brace-expansion, diff to fix ReDOS vulnerabilities
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // ============================================================================ | ||
| // 4. NOMINA CON HORAS EXTRA (Facturación por valores) | ||
| // ============================================================================ | ||
| async function nominaConHorasExtraByValues(client: FiscalapiClient): Promise<void> { |
| // ============================================================================ | ||
| // 5. NOMINA CON INCAPACIDADES (Facturación por valores) | ||
| // ============================================================================ | ||
| async function nominaConIncapacidadesByValues(client: FiscalapiClient): Promise<void> { |
| // ============================================================================ | ||
| // 6. NOMINA CON SNCF (Facturación por valores) | ||
| // ============================================================================ | ||
| async function nominaConSNCFByValues(client: FiscalapiClient): Promise<void> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resumen
Agrega soporte completo para crear facturas de nómina (CFDI 4.0 con complemento de nómina 1.2).
Cambios principales
Nuevos servicios:
Modelos de nómina:
Ejemplos:
Mejoras técnicas: