-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(projects): replace EternalFoundation with EternalShowcase, …
#207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…optimize animations, and remove `@xyflow/react`
✅ Deploy Preview for eternalcodeteam-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @vLuckyyy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a major refactor to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great improvement, replacing the EternalFoundation component with the more dynamic and visually engaging EternalShowcase. The removal of the @xyflow/react dependency and the optimization of animations using framer-motion's staggering capabilities significantly enhance both performance and user experience. My feedback includes a couple of suggestions to further refine the new components for better performance and maintainability.
| repeatType: "loop", | ||
| }} | ||
| > | ||
| {[...items, ...items, ...items].map((item, i) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The InfiniteMarquee component currently triplicates the items array. For a seamless loop with a -50% translation on the x-axis, duplicating the items ([...items, ...items]) is sufficient. This change reduces the number of DOM elements, which can improve performance, especially with a large number of items.
| {[...items, ...items, ...items].map((item, i) => ( | |
| {[...items, ...items].map((item, i) => ( |
| <EternalFoundation /> | ||
| <EternalShowcase /> | ||
|
|
||
| <div className="relative z-10 mx-auto max-w-[90rem] px-4 sm:px-6 lg:px-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…optimize animations, and remove
@xyflow/react