Fix get_curdir absolute parameter bug - conditional resolve() call #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_curdirfunction incapybara/utils/custom_path.pywas not respecting theabsoluteparameter. When called withabsolute=False, it still returned an absolute path instead of a relative path.Problem:
The issue was on line 23 where
.resolve()was called unconditionally:As shown in the issue screenshot, both calls returned the same absolute path:
Solution:
Changed the return statement to conditionally call
.resolve()based on theabsoluteparameter:After the fix:
get_curdir(path, absolute=True)returns absolute path (unchanged behavior)get_curdir(path, absolute=False)now correctly returns relative pathThis ensures backward compatibility since all existing usage in the codebase uses the default
absolute=Trueparameter.Fixes #29.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.