-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade next from 15.4.1 to 16.1.5 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645 - https://snyk.io/vuln/SNYK-JS-NEXT-15105315
Summary of ChangesHello @iamdrewfortini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated by Snyk, focuses on enhancing the project's security by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR from Snyk upgrades next to 16.1.5 in the docs package to address security vulnerabilities. While the upgrade is necessary, it's a major version bump and introduces version inconsistencies across the monorepo. I've left a comment highlighting the need to align next versions across all packages (apps/backend, apps/dashboard, docs) and to update related dependencies like eslint-config-next. Please also remember to manually update the pnpm-lock.yaml file as mentioned in the PR description. Careful testing is advised after applying these changes.
| "mermaid": "^11.6.0", | ||
| "minimatch": "^10.0.1", | ||
| "next": "15.4.1", | ||
| "next": "16.1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this upgrade fixes security vulnerabilities, it introduces version inconsistencies for the next package across the monorepo.
apps/backenduses15.4.1apps/dashboarduses16.0.0docsnow uses16.1.5
Using different versions of a core framework like Next.js in a monorepo can lead to subtle bugs and maintenance overhead. It's strongly recommended to align the next version across all packages.
Additionally, the eslint-config-next dependency in this package is at 15.3.2, which may be incompatible with next@16. Please consider upgrading it to a compatible version (e.g., ^16.1.5).
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Snyk has created this PR to fix 2 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
docs/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
SNYK-JS-NEXT-15105315
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling