-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade bcrypt from 5.1.1 to 6.0.0 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Summary of ChangesHello @iamdrewfortini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to bolster the security of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades bcrypt to version 6.0.0 to resolve a security vulnerability. While the upgrade is necessary, it's a major version bump that introduces critical breaking changes. The primary change is that bcrypt's asynchronous functions now return Promises instead of using callbacks. This requires code modifications wherever these functions are used. Additionally, the pnpm-lock.yaml file needs to be manually updated by running pnpm install. I've left a critical comment on the package.json change detailing the necessary actions to ensure the application continues to function correctly after this upgrade.
| "@vercel/otel": "^1.10.4", | ||
| "ai": "^4.3.17", | ||
| "bcrypt": "^5.1.1", | ||
| "bcrypt": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade for bcrypt which introduces breaking changes. It's critical to address these to prevent runtime failures.
-
Promise-based API: The asynchronous functions (
genSalt,hash,compare) now return Promises instead of accepting callbacks. All call sites for these functions must be updated. For example, callback-style code likebcrypt.hash(myPassword, salt, (err, hash) => { ... })should be refactored to useasync/await(const hash = await bcrypt.hash(myPassword, salt);) or.then(). -
Update Lockfile: As noted in the PR description,
pnpm-lock.yamlwas not automatically updated. You must runpnpm installmanually to update the lockfile. Without this, the old version ofbcryptmight still be used, or it could lead to dependency conflicts.
Given the nature of bcrypt in authentication flows, failing to address these points could break user sign-up and sign-in.
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
apps/backend/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.