-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade react-router-dom from 7.2.0 to 7.12.0 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908531 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908293 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908286 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908289 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908429
Summary of ChangesHello @iamdrewfortini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk upgrades react-router-dom to version 7.12.0 to resolve several security vulnerabilities. While the change in package.json is correct, it's crucial to note that the pnpm-lock.yaml file was not automatically updated, as mentioned in the PR description. You must manually run pnpm install and commit the updated lock file to ensure the security fix is actually applied across all environments. Failure to do so will leave your application vulnerable.
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "react-router-dom": "^7.2.0" | ||
| "react-router-dom": "^7.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in the pull request description, the pnpm-lock.yaml file has not been updated. This is a critical step that must be completed manually.
Without updating the lock file, your project will continue to use the old, vulnerable version of react-router-dom specified in the lock file, and the security fix will not be applied.
Please run pnpm install in the repository root to update pnpm-lock.yaml and commit the changes to this PR before merging.
Snyk has created this PR to fix 5 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
examples/react-example/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-REACTROUTER-14908531
SNYK-JS-REACTROUTER-14908293
SNYK-JS-REACTROUTER-14908286
SNYK-JS-REACTROUTER-14908289
SNYK-JS-REACTROUTER-14908429
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect
🦉 Cross-site Scripting (XSS)