-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade next from 14.2.3 to 15.5.10 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
Summary of ChangesHello @iamdrewfortini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the security of the project by updating a critical dependency. The primary goal is to mitigate a high-severity vulnerability found in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades next from version 14 to 15 to resolve a security vulnerability. While this is an important security fix, upgrading a major version of a framework like Next.js introduces significant breaking changes. The PR is currently incomplete and will likely break the build. I've added a comment highlighting the required updates for peer dependencies like react and react-dom to version 19, as well as the eslint-config-next package. Additionally, as noted in the PR description, the pnpm-lock.yaml file needs to be manually updated after applying these changes.
| "dependencies": { | ||
| "@stackframe/stack": "workspace:*", | ||
| "next": "^14.2", | ||
| "next": "^15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This major version upgrade of Next.js from v14 to v15 introduces breaking changes that require other dependencies to be updated as well:
-
React version (Critical): Next.js 15 requires React 19. The
reactandreact-domdependencies (and their corresponding@types/packages) need to be upgraded from^18to a compatible React 19 version (e.g.,^19.0.0-rc.0). Without this, the application will not work. -
ESLint config (High): The
eslint-config-nextdev dependency should be updated to match the new Next.js version (e.g.,15.5.10) to ensure linting rules are up-to-date and compatible.
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
examples/middleware/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling