-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade next from 14.2.3 to 15.5.10 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
Summary of ChangesHello @iamdrewfortini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR from Snyk upgrades next in examples/docs-examples to fix a security vulnerability. While the change is effective, it's a major version jump to 15.5.10. I've suggested a less disruptive alternative of upgrading to ^14.2.4, which also patches the vulnerability. A more critical issue is that other packages in this monorepo, specifically packages/stack and packages/template, also use a vulnerable version of next (^14.1.0) in their devDependencies. These have not been updated by this PR. To fully address the security risk, these dependencies should also be upgraded. Finally, please remember to manually update the pnpm-lock.yaml file as indicated in the PR description, as the automated process failed to do so.
| "@stackframe/stack-shared": "workspace:*", | ||
| "@stackframe/stack-ui": "workspace:*", | ||
| "next": "^14.1", | ||
| "next": "^15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to next@15.5.10 is a major version jump and could introduce breaking changes. To fix the security vulnerability with less risk, consider upgrading to the latest patch release of version 14, which is ^14.2.4. This will resolve the vulnerability without the potential disruption of a major version change.
| "next": "^15.5.10", | |
| "next": "^14.2.4", |
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
examples/docs-examples/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling