[MPDX-9267] Improve approval process card #1592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview branch generated at https://9267-approval-process-card.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against d51f585 No significant changes found |
wjames111
approved these changes
Jan 28, 2026
Contributor
wjames111
left a comment
wjames111
left a comment
There was a problem hiding this comment.
This looks great. I need to add something very similar for ASR, thanks for paving the way!
| overCapName, | ||
| overCapSalary, | ||
| } = useCaps(); | ||
| const overCombinedCap = |
Contributor
There was a problem hiding this comment.
Question: Do you think it makes sense to change this variable name now that it isn't calculating combined cap?
| sx={{ fontWeight: 'bold' }} | ||
| > | ||
| {t('Additional Information')} | ||
| {tier === ProgressiveApprovalTierEnum.DivisionHead |
Contributor
There was a problem hiding this comment.
I noticed this line a few times in this file, could we just assign it a variable?
Contributor
There was a problem hiding this comment.
Should we add tests for other division tiers now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MPDX-9267
Testing
Checklist:
/pr-reviewcommand locally and fixed any relevant suggestions