MPDX-9259 Get max values for ASR #1590
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, ASR is using hardcoded max values. Instead, we need to grab the max values from
SalaryInfographql query and validate the inputted number is at or below the max amount.Other things covered:
emailfield to queryJira ticket: MPDX-9259
Testing
Test max values:
/reports/additionalSalaryRequestTest UI updates:
Checklist:
/pr-reviewcommand locally and fixed any relevant suggestions