Skip to content

Conversation

@kegrimes
Copy link
Contributor

@kegrimes kegrimes commented Jan 27, 2026

Description

Currently, ASR is using hardcoded max values. Instead, we need to grab the max values from SalaryInfo graphql query and validate the inputted number is at or below the max amount.

Other things covered:

  • Updated amount textboxes to reflect UI figma designs
  • Updated contact information component (phone/email) to reflect UI designs --> might need to update backend to add email field to query

Jira ticket: MPDX-9259

Testing

Test max values:

  • Go to /reports/additionalSalaryRequest
  • Click "Edit Request" and enter values higher than max values
  • Verify that validation still works

Test UI updates:

  • Click "Edit Request" and update phone number and email
  • Enter invalid inputs to test validation
  • Check that values were saved

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@kegrimes kegrimes added the Preview Environment Add this label to create an Amplify Preview label Jan 27, 2026
@github-actions
Copy link
Contributor

Preview branch generated at https://mpdx-9259-get-max-values.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Bundle sizes [mpdx-react]

Compared against 0916c4b

No significant changes found

@kegrimes kegrimes added the Staging API Run GraphQL codegen against the staging API label Jan 28, 2026
@kegrimes kegrimes removed the Staging API Run GraphQL codegen against the staging API label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants